Bug fixes for unimplemented meta event #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran into this same issue, found the same fix and went to create a PR when I discovered this PR (wish I'd checked first). Anyhow, I recommend merging this fix. Thanks to all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug mentioned in issue 19. Since the same data is read twice, it cannot follow the file structure afterwards. This is simply solved by removing the unnecessary read function. I've attached a MIDI file to test it out in the link below. Before the fix, the data of MIDI messages came out in a jumbled mess. After the fix, it comes out as intended.
https://drive.google.com/file/d/1feeOInSjyom5dAI_OQcyW1-8AJeTiIKf/view?usp=sharing